PHPLIB-1596 Fully describe $search, $searchMeta and $vectorSearch stages
#1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
changed the title
$search and $searchMeta stages
GromNaN
force-pushed
the
PHPLIB-1596
branch
4 times, most recently
from
e433932 to
ba5c7b9
Compare
GromNaN
changed the title
$search and $searchMeta stages$search, $searchMeta and $vectorSearch stages
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jmikola
reviewed
Nov 26, 2024
GromNaN
commented
Nov 26, 2024
GromNaN
force-pushed
the
PHPLIB-1596
branch
3 times, most recently
from
2ea8f3a to
64e79e4
Compare
jmikola
reviewed
Nov 27, 2024
| @@ -145,6 +147,8 @@ private function convertYamlTaggedValues(mixed $object): mixed | |||
| 'bson_decimal128' => new Decimal128($value), | |||
| 'bson_utcdatetime' => new UTCDateTime(is_numeric($value) ? $value : new DateTimeImmutable($value)), | |||
| 'bson_binary' => new Binary(base64_decode($value)), | |||
| 'bson_objectId' => new ObjectId($value), | |||
| 'bson_uuid' => new Binary(hex2bin(str_replace('-', '', $value)), Binary::TYPE_UUID), | |||
There was a problem hiding this comment.
Because I was curious, I went back and compared the original code you had with pack('h*', ...). See below:
<?php
// Initialized project with: composer require ramsey/uuid
require 'vendor/autoload.php';
use Ramsey\Uuid\Uuid;
use MongoDB\BSON\Binary;
$uuid = Uuid::uuid4();
var_dump($uuid);
$bytes = $uuid->getBytes();
$str = $uuid->toString();
$bin = new Binary($bytes, Binary::TYPE_UUID);
var_dump(bin2hex($bin));
$bin2 = new Binary(hex2bin(str_replace('-','',$str)), Binary::TYPE_UUID);
var_dump($bin == $bin2);
$bin3 = new Binary(pack('h*', str_replace('-','',$str)), Binary::TYPE_UUID);
var_dump($bin == $bin3);
$bin4 = new Binary(pack('H*', str_replace('-','',$str)), Binary::TYPE_UUID);
var_dump($bin == $bin4);Output:
$ php foo.php
class Ramsey\Uuid\Lazy\LazyUuidFromString#4 (2) {
private ?Ramsey\Uuid\UuidInterface $unwrapped =>
NULL
private string $uuid =>
string(36) "3a6224c2-f648-4978-b510-610c04fbbcd6"
}
string(32) "3a6224c2f6484978b510610c04fbbcd6"
bool(true)
bool(false)
bool(true)
So it looks like h (hex string, low nibble first) wouldn't have worked, but H (high nibble first) would have. hex2bin() is totally fine, though, and easier to read.
|
|
||
| # The various example from the doc are variations of the "query" parameter | ||
| # this is not pertinent for testing the aggregation builder, unless we create | ||
| # a queryString builder. |
GromNaN
commented
Nov 27, 2024
| use MongoDB\Tests\Builder\PipelineTestCase; | ||
|
|
||
| /** | ||
| * Test in search |
There was a problem hiding this comment.
In fact, the search operators are not prefixed by the dollar sign 🤦.
I'll do a following PR to add quotes as this will impact all test classes (or maybe remove the comment).
GromNaN
force-pushed
the
PHPLIB-1596
branch
2 times, most recently
from
9b22965 to
9fe3bd1
Compare
jmikola
reviewed
Dec 3, 2024
jmikola
approved these changes
Dec 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1596
The parameters of the
$searchand$searchMetastages are currently not described. Changing the generic property object into a full list of named arguments would be a breaking change after the first release of this code, so it's now or never.For the tests, you can see the deep structure of options is not described. That's something we an do later.
GroupandDollarGroup, use property name map #1540OperatorInterface::getOperator()withOperatorInterface::NAMEconstant #1541